Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace manager configurations #23133

Conversation

rheabansal
Copy link
Contributor

@rheabansal rheabansal commented Mar 16, 2023

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 16, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
compared tags (via openapi-validator v2.0.0) new version base version
package-preview-2023-04 package-preview-2023-04(f8844a5) package-preview-2023-04(release-Sentinel-2023-04-01-preview)
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 16, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-js - @azure/arm-securityinsight - 1.0.0-beta.7
+	Interface MstiDataConnectorDataTypes no longer has parameter bingSafetyPhishingURL
+	Operation Incidents.createTeam has a new signature
+	Parameter logicAppResourceId of interface PlaybookActionProperties is now required
+	Removed Enum KnownEntityKind
+	Removed Enum KnownKind
+	Type of parameter additionalData of interface AccountEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface AzureResourceEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface CloudApplicationEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface DnsEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface EntityCommonProperties is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface EntityEdges is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface FileEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface FileHashEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface HostEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface HuntingBookmark is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface IoTDeviceEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface IpEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface MailClusterEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface MailMessageEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface MailboxEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface MalwareEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface NicEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface ProcessEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface RegistryKeyEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface RegistryValueEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface SecurityAlert is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface SecurityGroupEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface SubmissionMailEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface ThreatIntelligenceIndicatorModel is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface UrlEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter entityKind of interface ExpansionResultAggregation is changed from EntityKind to EntityKindEnum
+	Type of parameter entityKind of interface IncidentEntitiesResultsMetadata is changed from EntityKind to EntityKindEnum
+	Type of parameter kind of interface Entity is changed from EntityKind to EntityKindEnum
+	Type of parameter kind of interface MetadataDependencies is changed from Kind to string
+	Type of parameter kind of interface MetadataModel is changed from Kind to string
+	Type of parameter kind of interface MetadataPatch is changed from Kind to string
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-securityinsight - 2.0.0b2
+	Model MSTIDataConnectorDataTypes no longer has parameter bing_safety_phishing_url
+	Parameter logic_app_resource_id of model PlaybookActionProperties is now required
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 42df51055bd53d6d1d0dd45e6153b2d67871be62. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
  • ️✔️Azure.ResourceManager.SecurityInsights [View full logs]  [Preview SDK Changes]
    info	[Changelog]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs] Generate from 42df51055bd53d6d1d0dd45e6153b2d67871be62. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]
    cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.6.2
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.2>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-securityinsight [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added operation EntitiesOperations.run_playbook
    info	[Changelog]   - Added operation group AlertRuleOperations
    info	[Changelog]   - Added operation group GetTriggeredAnalyticsRuleRunsOperations
    info	[Changelog]   - Added operation group TriggeredAnalyticsRuleRunOperations
    info	[Changelog]   - Added operation group WorkspaceManagerConfigurationsOperations
    info	[Changelog]   - Added operation group WorkspaceManagerMembersOperations
    info	[Changelog]   - Model MTPDataConnector has a new parameter filtered_providers
    info	[Changelog]   - Model MTPDataConnectorDataTypes has a new parameter alerts
    info	[Changelog]   - Model MTPDataConnectorProperties has a new parameter filtered_providers
    info	[Changelog]
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog]   - Model MSTIDataConnectorDataTypes no longer has parameter bing_safety_phishing_url
    info	[Changelog]   - Parameter logic_app_resource_id of model PlaybookActionProperties is now required
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 42df51055bd53d6d1d0dd45e6153b2d67871be62. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-securityinsight [View full logs]  [Preview SDK Changes] Breaking Change Detected
    Only show 120 items here, please refer to log for details.
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface DnsEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter kind of interface Entity is changed from EntityKind to EntityKindEnum
    info	[Changelog]   - Type of parameter additionalData of interface EntityCommonProperties is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface EntityEdges is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter entityKind of interface ExpansionResultAggregation is changed from EntityKind to EntityKindEnum
    info	[Changelog]   - Type of parameter additionalData of interface FileEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface FileHashEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface HostEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface HuntingBookmark is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter entityKind of interface IncidentEntitiesResultsMetadata is changed from EntityKind to EntityKindEnum
    info	[Changelog]   - Type of parameter additionalData of interface IoTDeviceEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface IpEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface MailboxEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface MailClusterEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface MailMessageEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface MalwareEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter kind of interface MetadataDependencies is changed from Kind to string
    info	[Changelog]   - Type of parameter kind of interface MetadataModel is changed from Kind to string
    info	[Changelog]   - Type of parameter kind of interface MetadataPatch is changed from Kind to string
    info	[Changelog]   - Type of parameter additionalData of interface NicEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface ProcessEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface RegistryKeyEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface RegistryValueEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface SecurityAlert is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface SecurityGroupEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface SubmissionMailEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface ThreatIntelligenceIndicatorModel is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface UrlEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Removed Enum KnownEntityKind
    info	[Changelog]   - Removed Enum KnownKind
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
️❌ azure-resource-manager-schemas failed [Detail]
  • Failed [Logs] Generate from 42df51055bd53d6d1d0dd45e6153b2d67871be62. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] WARN old lockfile
    cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
    cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
    cmderr	[initScript.sh] npm WARN old lockfile
    cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
    cmderr	[initScript.sh] npm WARN old lockfile
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    warn	No file changes detected after generation
  • securityinsights/resource-manager [View full logs
️❌ azure-powershell failed [Detail]
  • Failed [Logs] Generate from 42df51055bd53d6d1d0dd45e6153b2d67871be62. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • Az.securityinsights [View full logs]  [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 16, 2023

Generated ApiView

Language Package Name ApiView Link
swagger Microsoft.SecurityInsights https://apiview.dev/Assemblies/Review/3e6ab88afe474ccb8c49dca01981dc6f
Java azure-resourcemanager-securityinsights https://apiview.dev/Assemblies/Review/a04a3c343b614e6a9b3acea925bf1b86
.Net Azure.ResourceManager.SecurityInsights There is no API change compared with the previous version
JavaScript @azure/arm-securityinsight https://apiview.dev/Assemblies/Review/fadc6ea02d66406e95fcf74ec3cae495

@openapi-workflow-bot
Copy link

Hi, @rheabansal Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @rheabansal
    Copy link
    Contributor Author

    rheabansal commented Mar 16, 2023

    Hello! We already have sign off on the WorkspaceManagerConfigurations from this PR: #21275 (as well as #22967)
    We were targeting a future version and need sign off again as the April version is now started :)

    Thank you!

    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 16, 2023
    @openapi-workflow-bot
    Copy link

    Hi, @rheabansal your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    …nel-2023-04-01-preview-WorkspaceManager-Configurations
    Copy link
    Member

    @TimLovellSmith TimLovellSmith left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    "responses": {
    "200": {
    "body": {
    "id": "/subscriptions/d0cfe6b2-9ac0-4464-9919-dccaee2e48c0/resourceGroups/myRg/providers/Microsoft.OperationalInsights/workspaces/myWorkspace/providers/Microsoft.SecurityInsights/workspaceManagerConfigurations/default",

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    default

    do you intend to make this a singleton ? https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-contracts.md#singleton-resources

    If so you can update the definition to remove the {workspaceManagerConfigurationName} variable and only allow default

    @raosuhas raosuhas added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Mar 20, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 20, 2023
    @tadelesh
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @tadelesh tadelesh merged commit d34d82b into Azure:release-Sentinel-2023-04-01-preview Mar 21, 2023
    tadelesh pushed a commit that referenced this pull request Apr 14, 2023
    * Adds base for updating Microsoft.SecurityInsights from version preview/2023-03-01-preview to version 2023-04-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Workspace Manager Members (#23134)
    
    * Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Workspace Manager Members
    
    * udpate pattern
    
    * Workspace manager configurations (#23133)
    
    * Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * adding april configurations swagger
    
    * update pattern
    
    * prettier update
    
    * update readme
    
    * Workspace manager assignments (#23130)
    
    * Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Workspace Manager Assignments/Jobs
    
    * update readme
    
    * updated from comments
    
    * update from lint diff errors
    
    * updated descriptions
    
    * Workspace manager groups (#23135)
    
    * Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * april swagger for groups
    
    * update path name & pattern
    
    * [Hunts] Add hunts to Sentinel 2023-04-01-preview version (#23139)
    
    * Add hunts files
    
    * Include update in 200 description and add defaults
    
    * Add back 201
    
    * Update relation properties
    
    * Update example
    
    ---------
    
    Co-authored-by: Derrick Lee <[email protected]>
    
    * Add readonly flag to providerName property (#23259)
    
    * sentinel content hub package and template API (#23151)
    
    * commit for content template and content package API
    
    * fix issues reported by swagger lint
    
    * add 201 for put requests in template service
    
    * resolve the comments
    
    * resolve comments in packageId
    
    * resolve comments
    
    * update descriptions due to lint error (#23392)
    
    * Fix policheck issue by updating the description. (#23415)
    
    * Fix polich issue by updating the description.
    
    * update the description to fix a typo.
    
    * Release sentinel 2023 04 01 preview (#23420)
    
    * Fix polich issue by updating the description.
    
    * update the description to fix a typo.
    
    * fix policheck by updating description
    
    * rename enum name to stable version to fix cross-version breaking change failure.
    
    * fix typo (#23463)
    
    ---------
    
    Co-authored-by: rheabansal <[email protected]>
    Co-authored-by: Derrick Lee <[email protected]>
    Co-authored-by: Derrick Lee <[email protected]>
    Co-authored-by: Anat Gilenson <[email protected]>
    Co-authored-by: xuhumsft <[email protected]>
    Co-authored-by: Nan Zang <[email protected]>
    JoshLove-msft pushed a commit to JoshLove-msft/azure-rest-api-specs that referenced this pull request Apr 25, 2023
    * Adds base for updating Microsoft.SecurityInsights from version preview/2023-03-01-preview to version 2023-04-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Workspace Manager Members (Azure#23134)
    
    * Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Workspace Manager Members
    
    * udpate pattern
    
    * Workspace manager configurations (Azure#23133)
    
    * Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * adding april configurations swagger
    
    * update pattern
    
    * prettier update
    
    * update readme
    
    * Workspace manager assignments (Azure#23130)
    
    * Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Workspace Manager Assignments/Jobs
    
    * update readme
    
    * updated from comments
    
    * update from lint diff errors
    
    * updated descriptions
    
    * Workspace manager groups (Azure#23135)
    
    * Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * april swagger for groups
    
    * update path name & pattern
    
    * [Hunts] Add hunts to Sentinel 2023-04-01-preview version (Azure#23139)
    
    * Add hunts files
    
    * Include update in 200 description and add defaults
    
    * Add back 201
    
    * Update relation properties
    
    * Update example
    
    ---------
    
    Co-authored-by: Derrick Lee <[email protected]>
    
    * Add readonly flag to providerName property (Azure#23259)
    
    * sentinel content hub package and template API (Azure#23151)
    
    * commit for content template and content package API
    
    * fix issues reported by swagger lint
    
    * add 201 for put requests in template service
    
    * resolve the comments
    
    * resolve comments in packageId
    
    * resolve comments
    
    * update descriptions due to lint error (Azure#23392)
    
    * Fix policheck issue by updating the description. (Azure#23415)
    
    * Fix polich issue by updating the description.
    
    * update the description to fix a typo.
    
    * Release sentinel 2023 04 01 preview (Azure#23420)
    
    * Fix polich issue by updating the description.
    
    * update the description to fix a typo.
    
    * fix policheck by updating description
    
    * rename enum name to stable version to fix cross-version breaking change failure.
    
    * fix typo (Azure#23463)
    
    ---------
    
    Co-authored-by: rheabansal <[email protected]>
    Co-authored-by: Derrick Lee <[email protected]>
    Co-authored-by: Derrick Lee <[email protected]>
    Co-authored-by: Anat Gilenson <[email protected]>
    Co-authored-by: xuhumsft <[email protected]>
    Co-authored-by: Nan Zang <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-JavaScript resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants